Skip to content

www: remove dynamic feature flag enableSchedulingProfiler #29994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

www: remove dynamic feature flag enableSchedulingProfiler #29994

merged 1 commit into from
Jun 20, 2024

Conversation

@kassens
Copy link
Member

@kassens kassens commented Jun 20, 2024 •
edited
Loading

No description provided.

@vercel
Copy link

vercel bot commented Jun 20, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jun 20, 2024
@react-sizebot
Copy link

react-sizebot commented Jun 20, 2024 •
edited
Loading

Comparing: 395e2fc...8145043

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.16% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.17 kB 597.17 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.52 kB 571.52 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMTesting-dev.classic.js = 1,089.26 kB 1,086.81 kB = 183.98 kB 183.73 kB
facebook-www/ReactDOM-dev.classic.js = 1,072.34 kB 1,069.90 kB = 180.02 kB 179.78 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,053.91 kB 1,051.45 kB = 177.62 kB 177.39 kB
facebook-www/ReactDOM-dev.modern.js = 1,037.00 kB 1,034.54 kB = 173.76 kB 173.54 kB
facebook-www/ReactReconciler-dev.classic.js = 730.64 kB 728.20 kB = 116.65 kB 116.41 kB
facebook-www/ReactReconciler-dev.modern.js = 706.85 kB 704.40 kB = 112.72 kB 112.52 kB
facebook-www/ReactART-dev.classic.js = 649.11 kB 646.67 kB = 104.10 kB 103.90 kB
facebook-www/ReactART-dev.modern.js = 626.73 kB 624.27 kB = 100.60 kB 100.40 kB
facebook-www/ReactDOM-profiling.classic.js = 626.93 kB 616.85 kB = 109.76 kB 108.49 kB
facebook-www/ReactDOM-profiling.modern.js = 600.64 kB 590.54 kB = 105.50 kB 104.26 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 8145043

@vercel
Copy link

vercel bot commented Jun 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:41pm

@kassens
Copy link
Member Author

kassens commented Jun 20, 2024 •
edited
Loading

Actually with dynamicFeatureFlags.enableSchedulingProfiler off on www, this should just be __DEV__.

@kassens kassens merged commit babe5a2 into facebook:main Jun 20, 2024
@kassens kassens deleted the pr29994 branch June 20, 2024 20:47
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@kassens
www: remove dynamic feature flag enableSchedulingProfiler (#29994)
07cbad5 
DiffTrain build for [babe5a2](babe5a2)
kassens added a commit that referenced this pull request Jun 20, 2024
@kassens
Revert "www: remove dynamic feature flag enableSchedulingProfiler (#2…
15fce08 
…9994)"

This reverts commit babe5a2.
@kassens kassens mentioned this pull request Jun 20, 2024
Merged
kassens added a commit that referenced this pull request Jun 20, 2024
@kassens
Revert "www: remove dynamic feature flag enableSchedulingProfiler" (#…
6ab67c3 
…29995)

Reverts #29994
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@kassens
Revert "www: remove dynamic feature flag enableSchedulingProfiler" (#…
2220b11 
…29995)

Reverts #29994

DiffTrain build for [6ab67c3](6ab67c3)
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yungsters yungsters yungsters approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

@josephsavona josephsavona Awaiting requested review from josephsavona

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kassens @react-sizebot @yungsters @facebook-github-bot